Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cal Video Links Expire After 14 Days #14557

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

joeauyeung
Copy link
Contributor

What does this PR do?

This PR changes the expiry date of Cal Video links from 1 hr to 14 days. New links are still generated on reschedule

CleanShot 2024-04-12 at 16 04 06@2x

CleanShot 2024-04-12 at 16 04 36@2x

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is a UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a booking with Cal Video
  • On the Daily dashboard, ensure the expiry date is set for 14 days

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@graphite-app graphite-app bot requested a review from a team April 12, 2024 20:05
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added cal video core area: core, team members only platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 12, 2024
@graphite-app graphite-app bot requested a review from a team April 12, 2024 20:05
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:16pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:16pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:16pm
qa-not-in-use ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:16pm

@joeauyeung joeauyeung changed the title Set expiry date to 14 days after end time fix: Cal Video Links Expire After 14 Days Apr 12, 2024
Copy link

graphite-app bot commented Apr 12, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 12, 2024

Current Playwright Test Results Summary

✅ 59 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/12/2024 08:48:56pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 294fe3f

Started: 04/12/2024 08:45:43pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests can add single organizer address location without display location public option
Retry 1Initial Attempt
0.29% (1) 1 / 346 run
failed over last 7 days
2.02% (7) 7 / 346 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@CarinaWolli CarinaWolli merged commit 902c441 into main Apr 12, 2024
38 of 39 checks passed
@CarinaWolli CarinaWolli deleted the daily-expire-in-14-days branch April 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working cal video consumer core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants