Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v2 app.rewrites.middleware.ts #14626

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: v2 app.rewrites.middleware.ts #14626

merged 1 commit into from
Apr 17, 2024

Conversation

supalarry
Copy link
Contributor

There is no such a thing as ".contains" in javascript for a string:

Screenshot 2024-04-17 at 10 45 25

there is ".includes" tho

Screenshot 2024-04-17 at 10 47 34

@graphite-app graphite-app bot requested a review from a team April 17, 2024 08:47
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Apr 17, 2024
@supalarry supalarry enabled auto-merge (squash) April 17, 2024 08:48
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Apr 17, 2024
@supalarry supalarry requested review from a team and removed request for a team April 17, 2024 08:48
Copy link

graphite-app bot commented Apr 17, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:49am

Copy link

deploysentinel bot commented Apr 17, 2024

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 12 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/17/2024 04:47:52pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 357288d

Started: 04/17/2024 04:43:54pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
4.23% (13) 13 / 307 runs
failed over last 7 days
40.39% (124) 124 / 307 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0.66% (2) 2 / 302 runs
failed over last 7 days
15.89% (48) 48 / 302 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-0.68% (-2) -2 / 295 runs
failed over last 7 days
63.39% (187) 187 / 295 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-171.56% (-187) -187 / 109 runs
failed over last 7 days
171.56% (187) 187 / 109 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-171.56% (-187) -187 / 109 runs
failed over last 7 days
171.56% (187) 187 / 109 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-168.81% (-184) -184 / 109 runs
failed over last 7 days
170.64% (186) 186 / 109 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-173.83% (-186) -186 / 107 runs
failed over last 7 days
173.83% (186) 186 / 107 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-173.83% (-186) -186 / 107 runs
failed over last 7 days
173.83% (186) 186 / 107 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-173.83% (-186) -186 / 107 runs
failed over last 7 days
173.83% (186) 186 / 107 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-173.83% (-186) -186 / 107 runs
failed over last 7 days
173.83% (186) 186 / 107 runs
flaked over last 7 days

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1Initial Attempt
2.22% (7) 7 / 316 runs
failed over last 7 days
7.28% (23) 23 / 316 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1Initial Attempt
0.34% (1) 1 / 298 run
failed over last 7 days
5.03% (15) 15 / 298 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Apr 17, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/video/[uid] 235.43 KB 463.84 KB 132.53% (🟢 -17.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow mind slipped on this one. Thank you 🙏🏼

@supalarry supalarry merged commit 51927f8 into main Apr 17, 2024
39 of 40 checks passed
@supalarry supalarry deleted the supalarry-patch-1 branch April 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants