Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: managed users check if exist #14649

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

Removing check to check if user already exist as it is already done taking into account the oAuthClientId inside of createOauthClientUser

@graphite-app graphite-app bot requested a review from a team April 18, 2024 07:47
Copy link
Contributor

github-actions bot commented Apr 18, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth core area: core, team members only platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 18, 2024
@graphite-app graphite-app bot requested a review from a team April 18, 2024 07:48
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Apr 18, 2024 1:55pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 1:55pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 1:55pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 1:55pm

Copy link

graphite-app bot commented Apr 18, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 18, 2024

Current Playwright Test Results Summary

✅ 127 Passing - ❌ 14 Failing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/18/2024 06:07:00pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: bac7a8b

Started: 04/18/2024 06:01:17pm UTC

❌ Failures

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Failures

Top 1 Common Error Messages

Failed to confirm payment. Response: [object Promise]

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 2Retry 1Initial Attempt
Error: Failed to confirm payment. Response: [object Promise]
Failed to confirm payment. Response: [object Promise]
7.05% (22) 22 / 312 runs
failed over last 7 days
2.56% (8) 8 / 312 runs
flaked over last 7 days
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 2Retry 1Initial Attempt
Error: Failed to confirm payment. Response: [object Promise]
Failed to confirm payment. Response: [object Promise]
6.75% (21) 21 / 311 runs
failed over last 7 days
2.57% (8) 8 / 311 runs
flaked over last 7 days

📄   apps/web/playwright/booking-limits.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Duration limits day
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for getByTestId('success-page')
  - waiting for getByTestId('success-page')

5.49% (18) 18 / 328 runs
failed over last 7 days
0% (0) 0 / 328 runs
flaked over last 7 days
Duration limits week
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for getByTestId('success-page')
  - waiting for getByTestId('success-page')

5.49% (18) 18 / 328 runs
failed over last 7 days
0% (0) 0 / 328 runs
flaked over last 7 days

📄   apps/web/playwright/dynamic-booking-pages.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
dynamic booking
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')

6.52% (21) 21 / 322 runs
failed over last 7 days
0% (0) 0 / 322 runs
flaked over last 7 days
Organization: Can book a time slot for an organization
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for getByTestId('success-page')
  - waiting for getByTestId('success-page')

5.59% (18) 18 / 322 runs
failed over last 7 days
0% (0) 0 / 322 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Collective EventType
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for getByTestId('success-page')
  - waiting for getByTestId('success-page')

7.25% (24) 24 / 331 runs
failed over last 7 days
0.30% (1) 1 / 331 run
flaked over last 7 days
Bookings User Event User Event with same slug as another user's booking is created for first user when first user is booked
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for getByTestId('success-page')
  - waiting for getByTestId('success-page')

5.83% (19) 19 / 326 runs
failed over last 7 days
0% (0) 0 / 326 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Collective EventType
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')

5.74% (19) 19 / 331 runs
failed over last 7 days
0.30% (1) 1 / 331 run
flaked over last 7 days
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')

6.04% (20) 20 / 331 runs
failed over last 7 days
8.46% (28) 28 / 331 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types Can create managed event type
Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
0.34% (1) 1 / 296 run
failed over last 7 days
4.39% (13) 13 / 296 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option
Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
0.93% (3) 3 / 321 runs
failed over last 7 days
3.43% (11) 11 / 321 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')

5.96% (19) 19 / 319 runs
failed over last 7 days
49.22% (157) 157 / 319 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 2Retry 1Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()...
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')

5.08% (16) 16 / 315 runs
failed over last 7 days
58.73% (185) 185 / 315 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can duplicate an existing event type
Retry 1Initial Attempt
0% (0) 0 / 322 runs
failed over last 7 days
6.21% (20) 20 / 322 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration when enabling Stripe, credentialId is included
Retry 1Initial Attempt
3.98% (13) 13 / 327 runs
failed over last 7 days
0.61% (2) 2 / 327 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Floating button Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
0% (0) 0 / 31 runs
failed over last 7 days
6.45% (2) 2 / 31 runs
flaked over last 7 days

View Detailed Build Results


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants