Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reschedule with google meet #14730
fix: reschedule with google meet #14730
Changes from 13 commits
d1f478b
21b1807
8fc26cf
4809a55
b5a6bfd
9d0d813
61eb4aa
aa56f3b
116b460
9a6eb6e
aeb58b2
b7f3ee1
2ad7d23
9745031
3e0efa6
25b2916
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 205 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L205
Check warning on line 206 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L206
Check warning on line 207 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L207
Check warning on line 208 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L208
Check warning on line 347 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L347
Check warning on line 348 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L348
Check warning on line 479 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L479
Check warning on line 480 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L480
Check warning on line 481 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L481
Check warning on line 484 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L484
Check warning on line 487 in apps/web/test/utils/bookingScenario/bookingScenario.ts
GitHub Actions / ESLint Report Analysis
apps/web/test/utils/bookingScenario/bookingScenario.ts#L487
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU, the issue occurred because the
originalEvent
didn't have videoCallData(because the booking was confirmed later and then the videoCallData isn't updated in bookingReference I guess(which I think we should do as a follow up - but it is a separate problem).The thing is that we should have used the latest link returned by the updateMeeting/updateEvent call(which is available in
updatedEvent
). We can fallback tocreatedEvent
just in case. It ensure that the link expiry is up-to-date(and maybe other details).Though I tested, and it makes sense that, during reschedule
createdEvent
won't be there. So, technically we should just useupdatedEvent
.const googleHangoutLink=(Array.isArray(googleCalResult?.updatedEvent) ? googleCalResult.updatedEvent[0]?.hangoutLink : googleCalResult?.updatedEvent?.hangoutLink)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about only using updatedEvent but when you reschedule and add a new guest in booking form then you would get createdEvent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool that's something i missed. But we should still prioritize
updatedEvent
overcreatedEvent
. Not sure if that change is done already.