Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Twipla app analytics added #14780

Merged
merged 6 commits into from
Jun 14, 2024
Merged

feat: Twipla app analytics added #14780

merged 6 commits into from
Jun 14, 2024

Conversation

vikaspatil0021
Copy link
Contributor

@vikaspatil0021 vikaspatil0021 commented Apr 28, 2024 •
edited
Loading

This PR is to add Twipla analytics in the app store

fixes: #14758

loom video:
https://www.loom.com/share/2e97fea489044271b7f6f3fe03ccc52a

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Add Twipla analytics application to an event type.
  • Open up the event page and it should automatically track it.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 28, 2024
@graphite-app graphite-app bot requested a review from a team April 28, 2024 02:39
@vercel Vercel
Copy link

vercel bot commented Apr 28, 2024

@vikaspatil0021 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar insights area: insights, analytics ✨ feature New feature or request labels Apr 28, 2024
@graphite-app graphite-app bot requested a review from a team April 28, 2024 02:40
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 28, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (04/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vikaspatil0021 vikaspatil0021 changed the title Feat/ Twipla app analytics added feat/ Twipla app analytics added Apr 28, 2024
@vikaspatil0021 vikaspatil0021 changed the title feat/ Twipla app analytics added feat: Twipla app analytics added Apr 28, 2024
@PeerRich
Copy link
Member

looks great! can you uncommit your yarn.lock? main/CONTRIBUTING.md#guidelines-for-committing-yarn-lockfile

@socket-security Socket Security
Copy link

socket-security bot commented Apr 29, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@vikaspatil0021
Copy link
Contributor Author

@PeerRich Any updates on this?

@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
@github-actions github-actions bot added app-store-template Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync labels May 14, 2024
@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 30, 2024
PeerRich
PeerRich previously approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you

@github-actions github-actions bot removed the Stale label Jun 2, 2024
@PeerRich PeerRich modified the milestones: v4.2, v4.3 Jun 3, 2024
hariombalhara
hariombalhara approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vikaspatil0021 🙏

@hariombalhara hariombalhara added this pull request to the merge queue Jun 14, 2024
Merged via the queue into calcom:main with commit 745f0b0 Jun 14, 2024
16 of 23 checks passed
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@vikaspatil0021 @PeerRich @p6l-richard
feat: twipla app added (calcom#14780)
2135190 
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

@PeerRich PeerRich PeerRich left review comments

Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar app-store-template Created by Linear-GitHub Sync community Created by Linear-GitHub Sync ✨ feature New feature or request insights area: insights, analytics Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

[CAL-3557] add twipla
4 participants
@vikaspatil0021 @PeerRich @hariombalhara @keithwillcode