-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Organization Admin scope to API V1 #14860
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Current Playwright Test Results Summary✅ 3 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/21/2024 08:08:41pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f0dab0c Started: 05/21/2024 08:08:06pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2 • Retry 1 • Initial Attempt |
20.66% (56)56 / 271 runsfailed over last 7 days |
34.32% (93)93 / 271 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Syed Ali Shahbaz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@alishaz-polymath @zomars Peeling out the integration tests skeleton to here so it's separated. We've already verified that all new integration tests added in this PR pass. |
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Syed Ali Shahbaz <syedshahbaz@Syeds-MacBook-Pro.local> Co-authored-by: zomars <zomars@me.com>
What does this PR do?
isAdmin
→isSystemWideAdmin
for added clarity by clarifying scope of access to be system wideisOrganizationOwnerOrAdmin
and the scope of access is the members of the organizationisOrganizationOwnerOrAdmin
on bookings endpoint as an example:This PR also adds Pagination to the bookings endpoint, accessible by passing
take
&page
parameters, where take represents the number of items in the resulting array and page represents the page number when taking 'take' number of items per page.For example, if there are 20 results, we can use take=5 and page=3 to get results 11-15.
Mandatory Tasks (DO NOT REMOVE)