Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: org-wide webhooks #15144

Merged
merged 8 commits into from
Jun 4, 2024
Merged

feat: org-wide webhooks #15144

merged 8 commits into from
Jun 4, 2024

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented May 21, 2024

What does this PR do?

The org wide webhook works for user and team events for that org.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Login using org owner credentials and go to the /settings/developer/webhooks page and click New Button to create a new webhook.
  • Notice that org is also included in the list of teams.
  • Create a new webhook for the org.
  • You can further test the webhook by creating bookings on user and/or team events.

@vercel Vercel
Copy link

vercel bot commented May 21, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 21, 2024
@graphite-app graphite-app bot requested a review from a team May 21, 2024 09:17
@github-actions github-actions bot added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs webhooks area: webhooks, callback, webhook payload ✨ feature New feature or request labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added this to the v4.2 milestone May 21, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 21, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/21/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

CarinaWolli
CarinaWolli requested changes May 28, 2024
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Left some comments that need to be addressed first 🙏

packages/features/bookings/lib/handleNewBooking.ts Outdated Show resolved Hide resolved
packages/features/bookings/lib/handleNewBooking.ts Outdated Show resolved Hide resolved
packages/features/instant-meeting/handleInstantMeeting.ts Show resolved Hide resolved
Udit-takkar
Udit-takkar reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-29 at 11 56 42 AM

org wide webhook Instant meeting created works fine but it doesn't show up here in event type setting which could be confusing to some users.

@kart1ka
Copy link
Contributor Author

kart1ka commented May 30, 2024

Screenshot 2024-05-29 at 11 56 42 AM

org wide webhook Instant meeting created works fine but it doesn't show up here in event type setting which could be confusing to some users.

Hi @Udit-takkar
As I understand, The "Instant Bookings" tab in the Event Type settings is designed to display the Instant Meeting Webhook added specifically to that Event Type.

Team and Individual User Webhooks with the "Instant Meeting Created" trigger event are also not displayed in the Event Type settings.

Do let me know if you would still like Org-wide webhooks with the "Instant Meeting Created" trigger event to be displayed in the Instant Bookings tab.

@github-actions github-actions bot added the 🚧 wip / in the making This is currently being worked on label Jun 4, 2024
@kart1ka
Copy link
Contributor Author

kart1ka commented Jun 4, 2024

Hi @CarinaWolli
Just wanted to check in on the status of this PR. I've made the changes you suggested. If there's anything else I need to do before merging, please let me know.

CarinaWolli
CarinaWolli approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @kart1ka 🙌🏻

@CarinaWolli CarinaWolli added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@CarinaWolli CarinaWolli added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@CarinaWolli CarinaWolli added this pull request to the merge queue Jun 4, 2024
Merged via the queue into calcom:main with commit 4017c0e Jun 4, 2024
16 of 23 checks passed
@CarinaWolli CarinaWolli mentioned this pull request Jun 13, 2024
Open
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@kart1ka @p6l-richard
feat: org-wide webhooks (calcom#15144)
0481137 
* feat: include org in teams list

* feat: org-wide webhooks

* Move getOrgIdFromMemberOrTeamId to packages/lib
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request High priority Created by Linear-GitHub Sync organizations area: organizations, orgs webhooks area: webhooks, callback, webhook payload 🚧 wip / in the making This is currently being worked on
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3595] Org-Wide Webhooks
3 participants
@kart1ka @CarinaWolli @Udit-takkar