Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove minimum of 2 teams for making an Org #15267

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented May 30, 2024

What does this PR do?

/claim #15263

https://www.loom.com/share/0c963c9c3e41429e9627ff2f8adbfe67?sid=c4fb3359-a4f3-45f9-a243-c71a61b06fab

The error (Could not invite the user as he might be part of another organization) thrown in Step-5 exists in the main branch as well. It probably occurs because the org owner is already added to the new org but we try to add it again, in Step-5, when we move the existing team, of which the owner is a part, to the new org.
Apart from that, the org is created successfully and everything else seems to work fine.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link

vercel bot commented May 30, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 30, 2024
@graphite-app graphite-app bot requested a review from a team May 30, 2024 16:05
@github-actions github-actions bot added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels May 30, 2024
Copy link
Contributor

github-actions bot commented May 30, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added this to the v4.2 milestone May 30, 2024
Copy link

graphite-app bot commented May 30, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/30/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@PeerRich
Copy link
Member

hey @kart1ka can you record a loom video?

@kart1ka
Copy link
Contributor Author

kart1ka commented Jun 1, 2024

hey @kart1ka can you record a loom video?

Hi @PeerRich

Here is the loom video:
https://www.loom.com/share/0c963c9c3e41429e9627ff2f8adbfe67?sid=c4fb3359-a4f3-45f9-a243-c71a61b06fab

The error (Could not invite the user as he might be part of another organization) thrown in Step-5 exists in the main branch as well. It probably occurs because the org owner is already added to the new org but we try to add him again, in Step-5, when we move the existing team, of which the owner is a part, to the new org.
Apart from that, the org is created successfully and everything else seems to work fine.

@github-actions github-actions bot added the 🚧 wip / in the making This is currently being worked on label Jun 4, 2024
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏

Even though your changes work, but we should use a different approach to solve it as suggested.

@hariombalhara hariombalhara added this pull request to the merge queue Jun 7, 2024
Merged via the queue into calcom:main with commit b310eb1 Jun 7, 2024
16 of 23 checks passed
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* feat: Remove min of 2 teams for making an Org

* Set ORG_MINIMUM_PUBLISHED_TEAMS_SELF_SERVE to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ✨ feature New feature or request High priority Created by Linear-GitHub Sync organizations area: organizations, orgs 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3835] Remove minimum of 2 teams for making an Organisation
3 participants