Feature/sso signup #1555
Merged
Feature/sso signup #1555
+1,546
−1,190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cal/calendso/EgvqHoJpAu9rBZcfR4DacXtuf28w |
…his is causing the first record to be retrieved instead of the AND query failing
…(as long as email matches)
# Conflicts: # pages/getting-started.tsx # yarn.lock
|
merged calcom/website#47 |
|
Tested Google, works like a charm :) |
alishaz-polymath
requested changes
Feb 2, 2022
|
Thanks @alishaz-polymath. Save button has been fixed now. For existing accounts I block login from another identity provider if the email has not been verified yet (for security reasons). Otherwise it will go through (just re-tested here). |
buschco
pushed a commit
to buschco/calendso
that referenced
this pull request
Mar 27, 2022
* updated saml-jackson * if logged in redirect to getting-started page with username in the query param * fixed issue with mixed up Google login, profile.id is undefined and this is causing the first record to be retrieved instead of the AND query failing * updated updated saml-jackson * document PGSSLMODE for Heroku * tweaks to PGSSLMODE doc * for self-hosted instance just allow user to signin with any identity (as long as email matches) * fixed submitting flag * added username to onboarding flow (if requested during signup) * added telemetry for google login, saml login, saml config * check if firstName and lastName are defined * convert mutation to an async op * added e2e test to ensure username query param gets picked up during onboarding * fixed minor typo and added note about configuring Google integration as an Internal app when self-hosting * cleaned up unnecessary ssr in sso signup routes * renamed function * Revert "cleaned up unnecessary ssr in sso signup routes" This reverts commit 3607ffe. * moved client side code to useEffect hook * - format - fixed Save button in SAML config component Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged with calendso/website#47
What does this PR do?
Updates saml-jackson and supports Google and SAML signup via a redirect from the Cal.com website. It also allows signing in with multiple identities for the same email (only for self-hosted instances)
Type of change
How should this be tested?
Checklist: