Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added playwright html reporter #1715

Merged
merged 17 commits into from Feb 8, 2022

Conversation

wilsongumba
Copy link
Contributor

@wilsongumba wilsongumba commented Feb 6, 2022

Adds playwright html reporter

This pr adds a html reporter and configures the list reporter for github actions. This is to enable ease of debug on the failed tests using the trace logs captured and specific steps where a test might fail. There are no dependencies required for this change.

Screenshot 2022-02-08 at 13 31 20

screen-recording-2022-02-08-at-133431_EZjmRnDW.mp4

Fixes # (N/A)

Test: Playwright configuration

  • Test configuration (non-breaking change)

How should this be tested?

See the README.md under the E2E-Testing

Locally

  • Checkout and run the project using yarn dx
  • Run the e2e tests in another terminal using yarn test-playwright. After a successful run, the report is saved in playwright/reports/playwright-html-report
  • After the run serve the latest report in another terminal using yarn playwright-report

In CI

  • The report should be uploaded under the artifacts
  • A summary of the passed, failed, skipped tests should be displayed under the annotations tab

Screenshot 2022-02-08 at 13 47 39

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Feb 6, 2022

@wilsongumba is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@PeerRich PeerRich requested a review from zomars February 7, 2022 19:58
@zomars
Copy link
Member

zomars commented Feb 7, 2022

Thank you for your contribution. Any reason why the PR template got ignored? What does this PR do? Why should we merge it? How should we test this?

If you could elaborate on these questions it will be greatly appreciated. 🙏

@wilsongumba
Copy link
Contributor Author

Thank you for your contribution. Any reason why the PR template got ignored? What does this PR do? Why should we merge it? How should we test this?

If you could elaborate on these questions it will be greatly appreciated. 🙏

Hi @zomars , i have updated the comment here please check. For any issues please reach out.

@zomars zomars self-assigned this Feb 8, 2022
@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/9pH5uo4yWeMHgmwnEruLSX864otD
✅ Preview: https://calendso-git-fork-wilsongumba-e2e-playwright-html-reporter-cal.vercel.app

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it seems this will help up debug a lot better. Thank you! 🙏🏽

.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Feb 8, 2022
@vercel vercel bot temporarily deployed to Preview February 8, 2022 16:17 Inactive
@zomars zomars enabled auto-merge (squash) February 8, 2022 16:24
@vercel vercel bot temporarily deployed to Preview February 8, 2022 16:26 Inactive
@zomars zomars merged commit 1976aa7 into calcom:main Feb 8, 2022
zomars added a commit that referenced this pull request Feb 15, 2022
* added playwright html reporter

* upload artifacts

* add junit reporter

* upload artifacts

* revert

* upload report as artifact

* upload only report in ci

* remove playwright cache

* revert caching

* upload reporter as artifact

* remove all cache

* revert changes

* Update .github/workflows/e2e.yml

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
buschco pushed a commit to buschco/calendso that referenced this pull request Mar 27, 2022
* added playwright html reporter

* upload artifacts

* add junit reporter

* upload artifacts

* revert

* upload report as artifact

* upload only report in ci

* remove playwright cache

* revert caching

* upload reporter as artifact

* remove all cache

* revert changes

* Update .github/workflows/e2e.yml

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants