Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks to support event type association #1889

Merged
merged 48 commits into from Mar 2, 2022
Merged

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Feb 17, 2022

What does this PR do?

  • Allows webhooks to be associated with event types as well (alongside users)
  • Allows webhook setup for team events
  • Componentifies custom template integration for webhooks
  • Only admins/owners are allowed to create/modify webhook for a team event

Demo: https://www.loom.com/share/3f011328f44945a08d3dfd09088840b3

Fixes #1579

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  1. Create a new team event
  2. Add a new webhook to the team event
  3. Make a booking and confirm that the webhook fired the payload to the endpoint

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/8Qz4wX8Su5EmjQXDLvRsUmNYCftr
✅ Preview: https://calendso-git-feature-team-webhooks-cal.vercel.app

[Deployment for b89dd4e canceled]

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/F1GadzsZzpRfuL7Xb6zbe6QfENXQ
✅ Preview: https://docs-git-feature-team-webhooks-cal.vercel.app

website – ./apps/website

🔍 Inspect: https://vercel.com/cal/website/EjB3gMepiwbjw1GtSyDdB4yG6Sce
✅ Preview: https://website-git-feature-team-webhooks-cal.vercel.app

[Deployment in progress for d6a0101]

calendso-staging – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso-staging/Bqw125D4uR3kaa8ZdPqficHNPaJ7
✅ Preview: Failed

[Deployment for 5342b45 failed]

website-staging – ./apps/website

🔍 Inspect: https://vercel.com/cal/website-staging/6uKBZnn5KvCP9MCSbwsuEU6QTbhR
✅ Preview: Canceled

[Deployment for d6a0101 canceled]

@alishaz-polymath alishaz-polymath self-assigned this Feb 17, 2022
@alishaz-polymath alishaz-polymath added ♻️ autoupdate tells kodiak to keep this branch up-to-date ✨ feature New feature or request ❗️ migrations contains migration files 🚧 wip / in the making This is currently being worked on labels Feb 17, 2022
@vercel vercel bot temporarily deployed to Preview – calendso February 17, 2022 10:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 17, 2022 10:35 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 17, 2022 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 17, 2022 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 17, 2022 15:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 17, 2022 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 17, 2022 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 17, 2022 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 18, 2022 00:27 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 00:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 18, 2022 01:13 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 01:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 18, 2022 03:14 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 03:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 18, 2022 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 16:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 18, 2022 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 18, 2022 17:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 28, 2022 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 28, 2022 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 28, 2022 23:08 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 28, 2022 23:08 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso March 1, 2022 09:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs March 1, 2022 09:51 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso March 1, 2022 11:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs March 1, 2022 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso March 1, 2022 19:24 Inactive
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve. Thank you!

@zomars zomars merged commit d338504 into main Mar 2, 2022
@zomars zomars deleted the feature/team-webhooks branch March 2, 2022 15:30
zomars added a commit that referenced this pull request Mar 2, 2022
zomars added a commit that referenced this pull request Mar 2, 2022
@zomars zomars restored the feature/team-webhooks branch March 2, 2022 15:53
zomars added a commit that referenced this pull request Mar 2, 2022
zomars added a commit that referenced this pull request Mar 2, 2022
* Revert "Revert "Webhooks to support event type association (#1889)" (#2032)"

This reverts commit 71e74b8.

* Fixes turbo DB deploy

* Update turbo.json
@alishaz-polymath alishaz-polymath deleted the feature/team-webhooks branch August 26, 2022 05:22
@CarinaWolli CarinaWolli mentioned this pull request Dec 20, 2022
1 task
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only ✨ feature New feature or request ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team webhooks
3 participants