Dynamic group booking fix to accept "+" in URL and updated Head SEO for dynamic booking #2414
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/27ZxLA9BRidu4p6KrYGDacYcGyjh [Deployment for 987bf90 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/5R3oz5LPFWzpNEieezXthuWFYCZX |
alishaz-polymath
added
🐛 bug
alishaz-polymath
added
👀 ready for review
and removed
🚧 wip / in the making
alishaz-polymath
changed the title
alishaz-polymath
changed the title
hariombalhara
approved these changes
Apr 7, 2022
| username={(user.username as string) || ""} | ||
| title={isDynamicGroup ? dynamicNames.join(", ") : nameOrUsername} | ||
| description={ | ||
| isDynamicGroup ? `Book events with ${dynamicUsernames.join(", ")}` : (user.bio as string) || "" |
There was a problem hiding this comment.
Maybe we should make it A, B and C?
baileypumfleet
approved these changes
Apr 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
+means a space only inapplication/x-www-form-urlencodedcontent, such as the query part of a URL (converting it to%20) and so it doesn't work for dynamic group booking currently, as+expected in the logic is expecting it encoded with %2b.This PR converts
" "or%20to+so that we can still accept+from the URL and allow it to do what we intended it to do in the first placeIt also considers dynamic group booking for HeadSEO details
[ref: Vercel]
[ref: Stackoverflow]
Type of change
How should this be tested?
/rick+proor/rick+freein staging and it should show the dynamic group booking page. Proceed with the booking normally.