Dynamic group link for more than 2 user fixed#2416
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/6nY8coJwNiutTaKsKy7FpgQjL9iL [Deployment for 4476294 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/AzwX7bQYuRBzZikF6sDNvAnKKr4Q |
alishaz-polymath
added
🐛 bug
alishaz-polymath
added
👀 ready for review
and removed
🚧 wip / in the making
alishaz-polymath
commented
Apr 7, 2022
| const profile = isDynamicGroup | ||
| ? { | ||
| name: getGroupName(usernameList), | ||
| name: getGroupName(dynamicNames), |
Member
Author
There was a problem hiding this comment.
Adds user's Names instead of username for title
| const profile = isDynamicGroupBooking | ||
| ? { | ||
| name: getGroupName(usernameList), | ||
| name: getGroupName(dynamicNames), |
Member
Author
There was a problem hiding this comment.
Uses Name isntead of username for title
| let combinedUsername = ``; | ||
| for (let i = 0; i < users.length - 1; i++) { | ||
| combinedUsername = `${users[i].username}+`; | ||
| let combinedUsername = `${users[0].username}`; |
Member
Author
There was a problem hiding this comment.
Fixes multi user username slug logic
hariombalhara
approved these changes
Apr 7, 2022
alishaz-polymath
added
🚧 wip / in the making
pumfleet
approved these changes
Apr 7, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Type of change
How should this be tested?
/pro+rick+free+usain staging