Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Event-Type 404 in case of unintentional duplicates. #3049

Merged
merged 4 commits into from Jun 13, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jun 13, 2022

What does this PR do?

Fixes #3034. Loom Video

Also Fixes

Note that: It is not possible to create duplicate events in a new account. But an existing account which has an event type with userId null, it is still possible to create one duplicate of such event type.

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

See looms

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 0:50AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 13, 2022 at 0:50AM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 13, 2022 at 0:50AM (UTC)
ui ⬜️ Ignored (Inspect) Jun 13, 2022 at 0:50AM (UTC)

@hariombalhara hariombalhara changed the title Fix sort order to ensure correct event-type is picked when duplicates Fix Event-Type 404 in case of unintentional duplicates. Jun 13, 2022
@hariombalhara hariombalhara marked this pull request as ready for review June 13, 2022 12:44
@hariombalhara hariombalhara added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Jun 13, 2022
@baileypumfleet baileypumfleet merged commit 5653282 into main Jun 13, 2022
@baileypumfleet baileypumfleet deleted the fix/404-event-type branch June 13, 2022 13:25
@zomars zomars mentioned this pull request Jun 15, 2022
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only
Projects
None yet
3 participants