Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom/Hubspot Tests with MSW mocking of requests initiated from Next.js server #3210

Merged
merged 86 commits into from
Aug 26, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jul 1, 2022

Fixes
#3177
#2255

Tests that verify

  • Zoom
    • Installation/Uninstallation.
    • Add zoom to an event-type and ensures that Zoom meeting is created
    • 2 Emails are sent with zoom links
  • Hubspot
    • Installation/Uninstallation

Approach

Tests with MSW require that playwright workers launch their own Next.js instance, so that within the tests we can mock requests based on the testcase

Known Limitations -

  • More than 1 workers don't currently work because our codebase doesn't support building once and then running with different ports. We need to use the port of the app itself when it was launched.
  • Due to the above limitation I am running these tests in separate workflow.yml so that they don't slow down other tests.

@vercel
Copy link

vercel bot commented Jul 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Aug 26, 2022 at 6:20PM (UTC)
cal-com ❌ Failed (Inspect) Aug 26, 2022 at 6:20PM (UTC)
nightly-cal ❌ Failed (Inspect) Aug 26, 2022 at 6:20PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Aug 26, 2022 at 6:20PM (UTC)
swagger ⬜️ Ignored (Inspect) Aug 26, 2022 at 6:20PM (UTC)
ui ⬜️ Ignored (Inspect) Aug 26, 2022 at 6:20PM (UTC)

@hariombalhara hariombalhara changed the title Add code from previous PR Zoom/Hubspot Tests Jul 1, 2022
@socket-security
Copy link

socket-security bot commented Jul 1, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
msw@0.42.3 (added) postinstall apps/web/package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules

Powered by socket.dev

@hariombalhara hariombalhara changed the title Zoom/Hubspot Tests Zoom/Hubspot Tests with MSW mocking of requests initiated from Next.js server Jul 1, 2022
@hariombalhara hariombalhara force-pushed the tests/with-msw branch 3 times, most recently from 5c2aecb to f89ca52 Compare July 1, 2022 12:57
@hariombalhara hariombalhara force-pushed the tests/with-msw branch 3 times, most recently from 2cbfb03 to 2919045 Compare July 1, 2022 13:23
@hariombalhara hariombalhara force-pushed the tests/with-msw branch 2 times, most recently from 5116354 to c886e17 Compare July 1, 2022 13:38
@hariombalhara hariombalhara force-pushed the tests/with-msw branch 2 times, most recently from 327705a to 37b9b3f Compare July 1, 2022 15:53
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 22, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@hariombalhara
Copy link
Member Author

@zomars @zlwaterfield Please review this. Should be quick one as it affects only tests and they are passing.

@zomars zomars merged commit 4ef666a into main Aug 26, 2022
@zomars zomars deleted the tests/with-msw branch August 26, 2022 18:44
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants