Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 500 on slack OAuth #3342

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Fixing 500 on slack OAuth #3342

merged 3 commits into from
Jul 12, 2022

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Jul 12, 2022

What does this PR do?

Slack OAuth flow was sending a 500 when we hit callback URL.

The error received in log was error - uncaughtException: Error [ERR_STREAM_WRITE_AFTER_END]: write after end

After some time debugging it seems the handler didn't like us returning this as it was causing headers to be changed after the requests was sent.

Fixes #3327

Environment: Staging(main branch) / Production

Loom : https://www.loom.com/share/17e080a9a8fc479a9e7bf58ba7b020c1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 8:30PM (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 8:30PM (UTC)
swagger ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 8:30PM (UTC)

Copy link
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sean-brydon sean-brydon enabled auto-merge (squash) July 12, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack app installation not working
4 participants