Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrating App Store to v2 #3911

Merged
merged 165 commits into from
Sep 5, 2022
Merged

feat: Migrating App Store to v2 #3911

merged 165 commits into from
Sep 5, 2022

Conversation

leog
Copy link
Contributor

@leog leog commented Aug 19, 2022

What does this PR do?

Migrating UI to v2

Screen.Recording.2022-09-01.at.12.38.22.mov

Implements #3777

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

Go to App Store page and see the new v2 UI shine ✨

@leog leog added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Sep 5, 2022
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some observations

  • Categories routes are returning 404. Example: /apps/categories/video, we should prevent that since these are probably widely shared and we should prevent 404s there.
  • We are using state for filtering, let's try moving that state to the URL and use shallow routing instead
  • There are multiple breakpoints where buttons break their container bounds:
2022-09-05.12-04-00.2022-09-05.12_05_55.mp4

packages/ui/v2/core/apps/AllApps.tsx Outdated Show resolved Hide resolved
packages/ui/v2/core/apps/AllApps.tsx Outdated Show resolved Hide resolved
@zomars zomars added ❗️ changes requested Waiting for the author to implement fixes/suggestions and removed ♻️ autoupdate tells kodiak to keep this branch up-to-date labels Sep 5, 2022
@leog
Copy link
Contributor Author

leog commented Sep 5, 2022

  • Categories routes are returning 404. Example: /apps/categories/video, we should prevent that since these are probably widely shared and we should prevent 404s there.

PR #4126 is ready to be merged after this one, so that should be taken care of.

@leog leog requested a review from zomars September 5, 2022 20:49
@leog leog removed the ❗️ changes requested Waiting for the author to implement fixes/suggestions label Sep 5, 2022
@zomars
Copy link
Member

zomars commented Sep 5, 2022

Changed #4126 target branch to feat/v2-app-store so it can be merged to this PR and merge both at the same time.

* Single category page

* Latest changes

* Applying feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2.0 Apps / App Store {View}
6 participants