feat: Migrating App Store to v2 #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomars
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Some observations
- Categories routes are returning 404. Example:
/apps/categories/video, we should prevent that since these are probably widely shared and we should prevent 404s there. - We are using state for filtering, let's try moving that state to the URL and use shallow routing instead
- There are multiple breakpoints where buttons break their container bounds:
2022-09-05.12-04-00.2022-09-05.12_05_55.mp4
zomars
added
❗️ changes requested
PR #4126 is ready to be merged after this one, so that should be taken care of. |
leog
removed
the
❗️ changes requested
|
Changed #4126 target branch to |
* Single category page * Latest changes * Applying feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrating UI to v2
Screen.Recording.2022-09-01.at.12.38.22.mov
Implements #3777
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Go to App Store page and see the new v2 UI shine ✨