-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 Workflows #4047
V2 Workflows #4047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @CarinaWolli. I've left some really minor comments in Loom. (Mostly they're design decisions that affect the app overall and where guidance wasn't provided - not workflow specific, so only do what makes sense in this pr from my suggestions.) Thank you 🙏
# Conflicts: # packages/ui/v2/core/EmptyScreen.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @CarinaWolli Added some deprecation comments and merging after all checks pass 🙏
@@ -0,0 +1,28 @@ | |||
import { GetStaticPaths, GetStaticProps } from "next"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add some deprecation comments to the v1 file
|
||
import { CONSOLE_URL } from "@calcom/lib/constants"; | ||
import { Icon } from "@calcom/ui/Icon"; | ||
import { EmptyScreen } from "@calcom/ui/v2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added deprecation notice
Thank you for your feedback @Jaibles 🙏 Feedback is implemented here: #4070 |
What does this PR do?
This PR adds the V2 design for Workflows.
Fixes #3793
Fixes #3792
Fixes #3791
Loom Video: https://www.loom.com/share/45c9e5a6e9c448ea871eb3dbdab55201
Loom Video Mobile: https://www.loom.com/share/0f455fa3528e475bb71c2a3374cf4638
Environment: Staging(main branch) / Production
How should this be tested?
Checklist