Add password on confirmation when changing email #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joeauyeung
commented
Sep 15, 2022
| }); | ||
| }, | ||
| }) | ||
| .mutation("verifyPassword", { |
There was a problem hiding this comment.
Added this new tRPC endpoint for in the future if we need to confirm passwords
emrysal
approved these changes
Sep 15, 2022
zomars
requested changes
Sep 15, 2022
|
Thanks for the feedback @zomars and @emrysal. The confirm password modal now appears only if the email was changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR prompts the user to confirm their password before changing their email.
Fixes # (issue)
https://www.loom.com/share/314277d527d0453a894f1d41741ce248
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist