Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have to correct tab order for addons. #4849

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

JeroenReumkens
Copy link
Contributor

@JeroenReumkens JeroenReumkens commented Oct 5, 2022

What does this PR do?

Ensures we have to correct tab order for addons. Before addons AFTER …the input still would get tab focus before the input.

https://www.loom.com/share/0e078015bddb48b4bb7b1d27986f934e

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Confirm that password peek gets focus after the input got focus
  • Verify other inputs' layout with leading and suffixed addons - see Loom and eg the event setup page.

…the input still would get tab focus before the input.
@JeroenReumkens JeroenReumkens changed the title Ensure we have to correct tabindexes for addons. Ensure we have to correct tab order for addons. Oct 5, 2022
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emrysal emrysal enabled auto-merge (squash) October 5, 2022 14:16
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 🚀

@emrysal emrysal merged commit d88bdc3 into main Oct 5, 2022
@emrysal emrysal deleted the fix/correct-tabindex-for-input-addons branch October 5, 2022 14:22
@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal 🔄 Building (Inspect) Oct 5, 2022 at 2:34PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants