Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Removed old v1 app components in web. #5286

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

JeroenReumkens
Copy link
Contributor

What does this PR do?

Cleanup: Removes v1 for app components in web app.

Environment: Staging(main branch)

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Ensure build still works
  • Check app pages for any weird behaviour. Especially since component removed from MDX (wasn't used anymore), double check the images as well.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 10:34AM (UTC)

@JeroenReumkens JeroenReumkens requested a review from a team October 31, 2022 10:31
@@ -3,6 +3,4 @@ items:
- /api/app-store/applecalendar/1.jpg
---

<Slider items={items} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slider was only used in V1. The new version uses the items array in the MDX meta.

@PeerRich PeerRich added automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Oct 31, 2022
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - So happy to be starting the migration to V2 files now :)

@PeerRich PeerRich merged commit 5c2ad78 into main Oct 31, 2022
@PeerRich PeerRich deleted the chore/remove-old-v1-app-components branch October 31, 2022 10:42
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date 🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants