New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Routing-Forms/Reporting #5375
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@harshsinghatz this isn't ready for review yet. It's in draft |
577bd56
to
11a4b5a
Compare
11a4b5a
to
df65630
Compare
df65630
to
b4bd83f
Compare
ef276c7
to
6c33ae8
Compare
Awesome feature, works great 🙌🏻 I only have a few design suggestions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the gray headline looks a bit dark, a lighter dark is better
also "Add Query" should be "Add Filter", no?
This is because the table is left aligned. The space at right would vary
Yeah I thought the same. The user can always filter the data to limit what loads on the page
Wanted to do it but it wasn't straightforward. Tables are tricky. Implemented it now. |
fd1cc9f
to
a2b82c2
Compare
a2b82c2
to
8e51325
Compare
62504dc
to
3bf5c69
Compare
What does this PR do?
Closes #5440
Demo
Environment: Production
Type of change
How should this be tested?
Note: You would see 2 unit tests check below. One is passing and the other is failing. This is because I have a fix for unit tests workflow in my PR which is passing and
main
one is failing