Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for test preview (routing forms) #5487

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Adds e2e tests for the new test preview in routing forms.

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 6:05AM (UTC)

@what-the-diff
Copy link

what-the-diff bot commented Nov 11, 2022

  • Added testid to the "Test Preview" button
  • Added testid to form fields and submit buttons in Test Routing modal
  • Updated tests for routing forms: added new tests that check if correct route is returned when user clicks on "Test preview" button, also updated existing tests with data-testids where needed

@hariombalhara
Copy link
Member

Looks good 🙏

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Nov 14, 2022
@kodiakhq kodiakhq bot merged commit 9e001c5 into main Nov 14, 2022
@kodiakhq kodiakhq bot deleted the testing/test-preview-routing-forms branch November 14, 2022 08:50
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants