Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing back sendgrid app to review #5501

Merged
merged 61 commits into from
Nov 17, 2022
Merged

Bringing back sendgrid app to review #5501

merged 61 commits into from
Nov 17, 2022

Conversation

leog
Copy link
Contributor

@leog leog commented Nov 12, 2022 •
edited
Loading

Bringing back reverted PR #5269 to review with @emrysal:

@leog leog requested a review from emrysal November 12, 2022 20:59
@leog leog self-assigned this Nov 12, 2022
@vercel
Copy link

vercel bot commented Nov 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 9:37PM (UTC)

@what-the-diff
Copy link

what-the-diff bot commented Nov 12, 2022

  • Added a new app
  • Updated the existing apps to use the latest version of @calcom/lib
  • Added a new app to the App Store
  • Created an API endpoint for adding and checking Sendgrid credentials
  • Implemented CalendarService class that will be used by Calendso's core in order to create events on behalf of users using their Sendgrid account (if they have one)
  • Added a new page to the app-store/sendgridothercalendar package
  • Updated CloseCom class in lib package with methods for creating custom activity types and fields, as well as getting lead id from Calcom generic Lead (if it exists) or create one if not found. Also added method for retrieving contact ids based on event attendees emails, which will also create contacts that don't exist yet but are required by the custom activity type instance data creation process.
  • Removed CloseComeUtils.ts
  • Added Sendgrid.ts
  • Added a new service: Sendgrid
  • Updated the CloseComService to use the newly created utils in @calcom/lib/CloseComeUtils

@leog leog mentioned this pull request Nov 12, 2022
Closed
@leog leog marked this pull request as ready for review November 16, 2022 21:43
@leog @zomars
Update apps/web/components/apps/OmniInstallAppButton.tsx
b9531a0 
Co-authored-by: Omar López <zomars@me.com>
zomars
zomars approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @leog LGTM!

LGTM

@leog leog enabled auto-merge (squash) November 17, 2022 19:48
@leog leog merged commit 1010e28 into main Nov 17, 2022
@leog leog deleted the feat/sendgrid-app branch November 17, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@emrysal emrysal Awaiting requested review from emrysal

Assignees

@leog leog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leog @zomars @PeerRich