Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team invites - transform email or username to lower case #6470

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Jan 13, 2023

What does this PR do?

This PR transforms the usernameOrEmail input to be lowercase. Currently, it is case-sensitive, which creates unique users based on the casing.

Fixes #6381

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Invite a user that does not exist to the team via email with alternating casing
    • In the DB the created user email should be lower case

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 6:58PM (UTC)

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @joeauyeung 🙏🏽

@zomars zomars added 🐛 bug Something isn't working ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Jan 13, 2023
@kodiakhq kodiakhq bot merged commit f96e909 into main Jan 13, 2023
@kodiakhq kodiakhq bot deleted the fix-team-invites branch January 13, 2023 18:58
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date 🐛 bug Something isn't working core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-740] Adding Team Member Potentially Broken
4 participants