Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode fixes #9141

Merged
merged 3 commits into from
May 29, 2023
Merged

fix: dark mode fixes #9141

merged 3 commits into from
May 29, 2023

Conversation

gitstart-calcom
Copy link
Contributor

@gitstart-calcom gitstart-calcom commented May 26, 2023

Fixes #9093

Demo

light mode: image

dark mode: image

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 3:02pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) May 26, 2023 3:02pm
ui ⬜️ Ignored (Inspect) Visit Preview May 26, 2023 3:02pm

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 256.2 KB 407.15 KB 116.33% (🟡 +0.14%)
/apps/[slug]/[...pages] 457.86 KB 608.81 KB 173.95% (🟢 -0.25%)
/auth/setup 174.22 KB 325.17 KB 92.91% (🟢 -0.16%)
/d/[link]/book 255.84 KB 406.79 KB 116.23% (🟡 +0.14%)
/event-types/[type] 479.43 KB 630.38 KB 180.11% (🟢 -0.19%)
/getting-started/[[...step]] 426.91 KB 577.86 KB 165.10% (🟡 +0.23%)
/new-booker/[user]/[type] 291.42 KB 442.37 KB 126.39% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 291.42 KB 442.37 KB 126.39% (🟡 +0.14%)
/settings/my-account/calendars 253.07 KB 404.02 KB 115.43% (🟡 +0.24%)
/team/[slug]/book 255.85 KB 406.8 KB 116.23% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented May 26, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/26/2023 03:24:20pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7c8194a

Started: 05/26/2023 03:12:42pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- old-booker enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 427 runs
failed over last 7 days
2.11% (9) 9 / 427 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 437 runs
failed over last 7 days
86.96% (380) 380 / 437 runs
flaked over last 7 days
Booking with Seats -- old-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 433 runs
failed over last 7 days
21.02% (91) 91 / 433 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Availability pages
Retry 1Initial Attempt
0% (0) 0 / 457 runs
failed over last 7 days
1.31% (6) 6 / 457 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added this pull request to the merge queue May 29, 2023
@PeerRich PeerRich removed this pull request from the merge queue due to the queue being cleared May 29, 2023
@PeerRich PeerRich merged commit df7870b into main May 29, 2023
@PeerRich PeerRich deleted the CALCOM-9093 branch May 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1759] dark mode fixes
4 participants