feat: API: /bookings optional end property - default to event length #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
emrysal
commented
Jun 2, 2023
| @@ -468,6 +468,13 @@ function getBookingData({ | |||
| if (val.responses) { | |||
| const unwantedProps: string[] = []; | |||
| legacyProps.forEach((legacyProp) => { | |||
| if (typeof val[legacyProp as keyof typeof val] !== "undefined") { | |||
There was a problem hiding this comment.
Unrelated, gives a warning when passing location or notes as a falsy value (but still present). Just log as this would be a breaking change.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 90 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/02/2023 07:06:40pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fab5231 Started: 06/02/2023 07:04:18pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- new-booker can add multiple organizer address
Retry 1 • Initial Attempt |
2.26% (8)8 / 354 runsfailed over last 7 days |
11.86% (42)42 / 354 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.40% (5)5 / 357 runsfailed over last 7 days |
19.89% (71)71 / 357 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0% (0)0 / 246 runsfailed over last 7 days |
15.45% (38)38 / 246 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows not having to manually compute the end of the booking, instead use eventType settings.