Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxError: Unexpected token 'for' #123

Open
Th0masDB opened this issue May 24, 2022 · 2 comments · May be fixed by #147
Open

SyntaxError: Unexpected token 'for' #123

Th0masDB opened this issue May 24, 2022 · 2 comments · May be fixed by #147

Comments

@Th0masDB
Copy link

When I was installing calcom for the first time, I got this error (I used this DOCKER_BUILDKIT=0 docker compose build calcom to build it):

/calcom/scripts/start.sh:4
scripts/wait-for-it.sh ${DATABASE_HOST} -- echo "database is up"
             ^^^

SyntaxError: Unexpected token 'for'
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
    at internal/main/run_main_module.js:17:47
@krumware
Copy link
Member

I'm unable to replicate the issue.
Can you please updating line 4 of start.sh to ./scripts/wait-for-it.sh ${DATABASE_HOST} -- echo "database is up"
(add the beginning ./)

Leopere pushed a commit to Leopere/calcom-docker that referenced this issue Aug 1, 2022
Significant Refactor.
73b2e61 
- added numerous environment variable changes such as implied defaults that can be overriden.
- skipped out on using git modules and just pull repo into build/launch step.  Adherance to license requires no repackaging and this solves this.
- cleaned up now unnecessary .env file.
- recycled environment section using yaml features.
- writing a few strings to config path to persist data between container starts that focus on cryptography and secrets.
- writing installed commit to the config path in case the end user needs to change the upstream git commit ID to a newer version for detection and automagic upgrades.
- added docker-compose.override.yml pattern to .gitignore to allow users to customize their local dev environment if they use docker-compose.yml
- wrote a dockerfile/container image which allows for uploading the base container to a private or public docker container registry without breaking the license rules.
- left .env ignore in case users wish to continue to use the old method.
- updated README.md to include updated simplified instructions.
- added start.sh script and wait-for-it.sh into the shell $PATH to allow for a potential future of allowing the main executable (node JS app) to run under a limited privilege user while still allowing the init scripts to be executed securely.
- added some input sanitation for certain critical variables.
- by default disabled/commented out the studio service as its not to typically be run to enforce better default deployment practices.  I would like to figure out what specific query to execute via the CLI instead of running a whole container to establish the first user in the end.
- wrote relatively unopinionated docker-compose.yml file to avoid causing problems for people trying to deploy this behind a reverse proxy for potential features such as TLS/HTTPS termination.
- upgraded compose version to latest '3.9' to be sure to enable most modern feature set.

Fixes calcom#87 by providing a working baseline with sober defaults.
Fixes calcom#88 by ensuring consistency across all containers Environment vars.
Fixes calcom#93 by allowing users to mount the application files within their IDE workspace, however, this will never solve for any times you will need to run yarn build steps.
Fixes calcom#99 by no longer using git submodules and just pulling a single commit depth copy of the ORIGIN repository on app bootstrap/first boot.
Fixes calcom#113 by no longer requiring build locally if the community maintainer of the Cal docker repository on GitHub will push this image to the hub.
Fixes calcom#121 by removing dependency on BuildKit this is done by simply deploying the app if its detected to be the first execution of this container be it due to no container persistence or a commit version upgrade from ORIGIN.
Fixes calcom#128 by removing dep on BuildKit
Fixes calcom#123 not replicatable and confirmed to be working in repository shipped state.
Fixes calcom#136 by building app on first launch from user define-able envvars which can be defined in numerous ways.
@Leopere Leopere linked a pull request Aug 1, 2022 that will close this issue
Draft
@Mistic92
Copy link

Mistic92 commented Aug 12, 2022 •
edited
Loading

I have the same issue. I tried to rename script to remove for but now I get

 /calcom/scripts/start.sh:4
calcom-docker-calcom-1  | scripts/wait_it.sh ${DATABASE_HOST} -- echo "database is up"
calcom-docker-calcom-1  |                    ^
calcom-docker-calcom-1  | 
calcom-docker-calcom-1  | SyntaxError: Unexpected identifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Significant Refactor Leopere/calcom-docker
3 participants
@Mistic92 @Th0masDB @krumware