Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git is asking for username #99

Closed
mokkin opened this issue Apr 17, 2022 · 16 comments · May be fixed by #147
Closed

git is asking for username #99

mokkin opened this issue Apr 17, 2022 · 16 comments · May be fixed by #147

Comments

@mokkin
Copy link
Contributor

mokkin commented Apr 17, 2022

The git clone command is asking for usernames now. Is that right?

git clone --recursive https://github.com/calendso/docker.git calendso-docker
Cloning into 'calendso-docker'...
remote: Enumerating objects: 617, done.
remote: Counting objects: 100% (617/617), done.
remote: Compressing objects: 100% (320/320), done.
remote: Total 617 (delta 305), reused 589 (delta 287), pack-reused 0
Receiving objects: 100% (617/617), 101.75 KiB | 9.25 MiB/s, done.
Resolving deltas: 100% (305/305), done.
Submodule 'calendso' (https://github.com/calcom/cal.com.git) registered for path 'calendso'
Cloning into '/root/calendso-docker/calendso'...
remote: Enumerating objects: 34822, done.        
remote: Counting objects: 100% (812/812), done.        
remote: Compressing objects: 100% (589/589), done.        
remote: Total 34822 (delta 460), reused 396 (delta 208), pack-reused 34010        
Receiving objects: 100% (34822/34822), 28.34 MiB | 9.00 MiB/s, done.
Resolving deltas: 100% (21770/21770), done.
Submodule path 'calendso': checked out '73c97e85d457c0f2fcb34d29b380018fe81edbd3'
Submodule 'apps/api' (https://github.com/calcom/api.git) registered for path 'calendso/apps/api'
Submodule 'apps/website' (https://github.com/calcom/website.git) registered for path 'calendso/apps/website'
Cloning into '/root/calendso-docker/calendso/apps/api'...
Username for 'https://github.com': 

Ubuntu 20.04

@PeerRich
Copy link
Member

@zomars I believe the submodules may be causing some issues right now?

@PeerRich
Copy link
Member

@krumware did you found a way?

@zomars
Copy link
Member

zomars commented Apr 18, 2022

@zomars I believe the submodules may be causing some issues right now?

It is submodule related yes. But it shouldn't ask for a username. Maybe switch from https to ssh in gitmodules could help. Or remove them altogether from docker

@krumware
Copy link
Member

krumware commented Apr 19, 2022

It's submodule related and likely because the API submodule references a private repository. Hoping to discuss this today.

@rohanrajpal
Copy link

Facing the same issue

ubuntu@ip-172-31-6-102 ~/calcom [128]> git clone --recursive https://github.com/calendso/docker.git calendso-docker
Cloning into 'calendso-docker'...
remote: Enumerating objects: 631, done.
remote: Counting objects: 100% (631/631), done.
remote: Compressing objects: 100% (332/332), done.
remote: Total 631 (delta 313), reused 595 (delta 289), pack-reused 0
Receiving objects: 100% (631/631), 103.81 KiB | 12.98 MiB/s, done.
Resolving deltas: 100% (313/313), done.
Submodule 'calendso' (https://github.com/calcom/cal.com.git) registered for path 'calendso'
Cloning into '/home/ubuntu/calcom/calendso-docker/calendso'...
remote: Enumerating objects: 36055, done.        
remote: Counting objects: 100% (3/3), done.        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 36055 (delta 0), reused 3 (delta 0), pack-reused 36052        
Receiving objects: 100% (36055/36055), 47.72 MiB | 10.62 MiB/s, done.
Resolving deltas: 100% (22646/22646), done.
Submodule path 'calendso': checked out '6e82d38249058427fa065c50ceaf4a324aeb1b9b'
Submodule 'apps/admin' (https://github.com/calcom/admin.git) registered for path 'calendso/apps/admin'
Submodule 'apps/api' (https://github.com/calcom/api.git) registered for path 'calendso/apps/api'
Submodule 'apps/website' (https://github.com/calcom/website.git) registered for path 'calendso/apps/website'
Cloning into '/home/ubuntu/calcom/calendso-docker/calendso/apps/admin'...
Username for 'https://github.com': rohanrajpal

@PeerRich
Copy link
Member

we're discussing this issue right now 🙏

@AmoghSaxena AmoghSaxena pinned this issue Apr 21, 2022
@krumware
Copy link
Member

Creating a new GH issue to track docker changes to address these things

@narzero
Copy link

narzero commented Apr 22, 2022

Experiencing the same issue myself

@krumware
Copy link
Member

Fix for this is in progress

@krumware
Copy link
Member

can you please retry with latest and latest instructions?

@krumware krumware unpinned this issue Apr 29, 2022
@fcoscarello
Copy link

fcoscarello commented May 1, 2022

Keeps asking for credentials with the latest instructions

[fran@host ~]$ git clone --recursive https://github.com/calcom/docker.git calcom-docker
Cloning into 'calcom-docker'...
remote: Enumerating objects: 735, done.
remote: Counting objects: 100% (82/82), done.
remote: Compressing objects: 100% (59/59), done.
remote: Total 735 (delta 38), reused 59 (delta 21), pack-reused 653
Receiving objects: 100% (735/735), 125.63 KiB | 0 bytes/s, done.
Resolving deltas: 100% (357/357), done.
Submodule 'calcom' (https://github.com/calcom/cal.com.git) registered for path 'calcom'
Cloning into 'calcom'...
remote: Enumerating objects: 37344, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 37344 (delta 0), reused 5 (delta 0), pack-reused 37339
Receiving objects: 100% (37344/37344), 49.01 MiB | 6.52 MiB/s, done.
Resolving deltas: 100% (23622/23622), done.
Submodule path 'calcom': checked out '276821e0b5cb9603e052f76aba10c451bbd3f9c9'
Submodule 'apps/admin' (https://github.com/calcom/admin.git) registered for path 'apps/admin'
Submodule 'apps/api' (https://github.com/calcom/api.git) registered for path 'apps/api'
Submodule 'apps/website' (https://github.com/calcom/website.git) registered for path 'apps/website'
Cloning into 'apps/admin'...
Username for 'https://github.com':

@scantreed
Copy link

After following the instructions I'm still experiencing the same issues as well

@krumware
Copy link
Member

krumware commented May 5, 2022

AH, the --recursive is still there. I'll fix that immediately.
Please try with a regular clone and not --recursive

@krumware
Copy link
Member

krumware commented May 5, 2022

The instruction in the readme is now corrected

@scantreed
Copy link

Thanks @krumware

Leopere pushed a commit to Leopere/calcom-docker that referenced this issue Aug 1, 2022
- added numerous environment variable changes such as implied defaults that can be overriden.
- skipped out on using git modules and just pull repo into build/launch step.  Adherance to license requires no repackaging and this solves this.
- cleaned up now unnecessary .env file.
- recycled environment section using yaml features.
- writing a few strings to config path to persist data between container starts that focus on cryptography and secrets.
- writing installed commit to the config path in case the end user needs to change the upstream git commit ID to a newer version for detection and automagic upgrades.
- added docker-compose.override.yml pattern to .gitignore to allow users to customize their local dev environment if they use docker-compose.yml
- wrote a dockerfile/container image which allows for uploading the base container to a private or public docker container registry without breaking the license rules.
- left .env ignore in case users wish to continue to use the old method.
- updated README.md to include updated simplified instructions.
- added start.sh script and wait-for-it.sh into the shell $PATH to allow for a potential future of allowing the main executable (node JS app) to run under a limited privilege user while still allowing the init scripts to be executed securely.
- added some input sanitation for certain critical variables.
- by default disabled/commented out the studio service as its not to typically be run to enforce better default deployment practices.  I would like to figure out what specific query to execute via the CLI instead of running a whole container to establish the first user in the end.
- wrote relatively unopinionated docker-compose.yml file to avoid causing problems for people trying to deploy this behind a reverse proxy for potential features such as TLS/HTTPS termination.
- upgraded compose version to latest '3.9' to be sure to enable most modern feature set.

Fixes calcom#87 by providing a working baseline with sober defaults.
Fixes calcom#88 by ensuring consistency across all containers Environment vars.
Fixes calcom#93 by allowing users to mount the application files within their IDE workspace, however, this will never solve for any times you will need to run yarn build steps.
Fixes calcom#99 by no longer using git submodules and just pulling a single commit depth copy of the ORIGIN repository on app bootstrap/first boot.
Fixes calcom#113 by no longer requiring build locally if the community maintainer of the Cal docker repository on GitHub will push this image to the hub.
Fixes calcom#121 by removing dependency on BuildKit this is done by simply deploying the app if its detected to be the first execution of this container be it due to no container persistence or a commit version upgrade from ORIGIN.
Fixes calcom#128 by removing dep on BuildKit
Fixes calcom#123 not replicatable and confirmed to be working in repository shipped state.
Fixes calcom#136 by building app on first launch from user define-able envvars which can be defined in numerous ways.
@krumware
Copy link
Member

Closing as resolved.
If you landed here, this issue is usually related to attempting to initialize submodules with recursive mode, as git will fail to pull repositories that are optional and not publicly available. Contact @PeerRich for information about access to the private repositories available with enterprise licenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants