Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace difference with diff? #4

Closed
swsnr opened this issue Mar 13, 2021 · 3 comments
Closed

Replace difference with diff? #4

swsnr opened this issue Mar 13, 2021 · 3 comments

Comments

@swsnr
Copy link

swsnr commented Mar 13, 2021

cargo audit reports that difference is unmaintained:

Crate:  difference
Title:  difference is unmaintained
Date:   2020-12-20
URL:    https://rustsec.org/advisories/RUSTSEC-2020-0095

pretty-assertions switched to the diff crate; would this work for this crate as well?
@calder
Copy link
Owner

calder commented Apr 4, 2021

It should, yeah! PRs welcome!

@swsnr
Copy link
Author

swsnr commented Apr 6, 2021

I can make one for sure, but will you review and release it soonish?

I am sorry, and I mean no offense, but you took some time to reply with just a fairly standard answer, so please do forgive me for being a bit sceptical 😔

@swsnr
Copy link
Author

swsnr commented Apr 30, 2021

All right then 🙂

@swsnr swsnr closed this as completed Apr 30, 2021
swsnr added a commit to swsnr/mdcat that referenced this issue May 1, 2021
@swsnr
Drop goldenfile dependency
51d4038 
It's trivial to replace and not exactly enthusiastically maintained, see
calder/rust-goldenfile#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calder @swsnr