Skip to content

Commit

Permalink
feat(deps): update dependency eslint-plugin-unicorn to v20 (#206)
Browse files Browse the repository at this point in the history
  • Loading branch information
renovate[bot] committed May 18, 2020
1 parent 18f42c3 commit 0910154
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
16 changes: 4 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"eslint-plugin-react": "7.19.0",
"eslint-plugin-react-hooks": "4.0.0",
"eslint-plugin-standard": "4.0.1",
"eslint-plugin-unicorn": "19.0.1"
"eslint-plugin-unicorn": "20.0.0"
},
"devDependencies": {
"@babel/core": "7.9.6",
Expand Down
2 changes: 2 additions & 0 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ module.exports.configs = {
'unicorn/no-fn-reference-in-iterator': 'off', // The situation where this rule would trigger usefully is very very rare. It probably triggers useslessly at least 10x as often. This can be caught by manual code review
'unicorn/better-regex': ['error', { sortCharacterClasses: false }],
'unicorn/consistent-function-scoping': 'off', // I like the idea of this rule, but it seems like it triggers too often in cases where the code is "correct"
'unicorn/no-useless-undefined': 'off', // Removing undefined can cause TS errors
'unicorn/no-reduce': 'off', // Reduce is often useful
'no-else-return': ['error', { allowElseIf: true }],
'no-await-in-loop': 'off', // Sometimes I want to await in a loop. I don't see why this is a problem
'no-async-promise-executor': 'off', // it is convenient sometimes to await in promise executor
Expand Down

0 comments on commit 0910154

Please sign in to comment.