New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some convenience improvements #3

Merged

faisaltheparttimecoder merged 2 commits into calendarific:master from arieroos:master

Nov 15, 2022

arieroos commented Nov 15, 2022 •

edited

Loading

Thanks for this project. It is nice to not have to write Http requests, but to have a convenient way to interface with the API.

I have made two improvements to make the library a little more convenient:

I separated the Holiday struct into it's own type, this better leverages Go's static typing. It is nice to able to work with a Holiday struct, as that is the most meaningful data coming from the API.
I added a field to the Holiday struct called GoDate. This field contains the holiday's date in the native time.Time type, which is convenient to work with.

I know it's bad form to add two features in one PR, but I figured this repo is small enough

Arie De Bok added 2 commits

November 15, 2022 15:14


          Make Holiday a separate type

a25d3a2


          Add a GoDate with go's native time.Time type

ac0cf6f

faisaltheparttimecoder merged commit 30c5173 into calendarific:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet