Fix runtime memory leaks on MSVC #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Like mentioned in LMMS#10, this issue occurs 2 more times in the same file. I would recommend to fix it there, too.
Done. Thanks for the catch. |
Rossmaxx
changed the title
|
Just for info, your PR is appreciated, but before I will merge it, I would like to set up the Windows CI for this repo, so apologies for the waiting time. |
|
No issues. Take your time. |
|
Tested and CI passed. Thanks for the submission, I will merge this one. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi from the LMMS team. I'm working on adding LADSPA support to MSVC. Someone had attempted to add ladspa support around a year ago and have upstreamed some changes. They fixed all compile time issues but they left out one runtime issue, ie the limiter crashes on the MSVC build of LMMS.
The fix :
STACKALLOCuses VLAs on other platforms and_alloca()on MSVC, because MSVC doesn't support VLAs. But the problem with using_alloca()inside the loop is that it leads to buffer overflow, so I moved it out of the loop. Looks like a rather harmless change and doesn't seem to cause any issues so far, though further testing is appreciated.