Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in symlink to euro-calliope-lib #374

Open
timtroendle opened this issue May 13, 2024 · 3 comments
Open

Fix regression in symlink to euro-calliope-lib #374

timtroendle opened this issue May 13, 2024 · 3 comments
Labels
bug Something isn't working workflow Related to the design and execution of the workflow.

Comments

@timtroendle
Copy link
Member

What happened?

The symlink to euro-calliope-lib is not created if it doesn't exist. This leads to failure when trying to create new conda environments.

This used to work and it is a regression, potentially introduced in #331.

Version

1.2.0.dev

Relevant log output

No response

@timtroendle timtroendle added bug Something isn't working workflow Related to the design and execution of the workflow. labels May 13, 2024
@brynpickering
Copy link
Member

I don't quite see how #331 could have introduced this. Its only addition is to delete the symlink if it is invalid. The later line to create the symlink is still there.

@timtroendle
Copy link
Member Author

Agree. In fact, it's #330 that I thought of.

Either way, I am pretty sure this worked just fine when I introduced it in #264 and it now seems broken.

@timtroendle
Copy link
Member Author

Also: This mechanism is quite a hack, anyways. Handling the lib in a separate repo sounds like the cleaner approach that would not require any hacks like this (see #207).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow Related to the design and execution of the workflow.
Projects
None yet
Development

No branches or pull requests

2 participants