Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to snakemake 8 #330

Merged

Conversation

sjpfenninger
Copy link
Member

@sjpfenninger sjpfenninger commented Apr 9, 2024

Fixes #289.

The required changes seem rather minimal. The minimal config successfully runs. use-conda is deprecated and I replaced it with software-deployment-method: conda.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

@sjpfenninger sjpfenninger marked this pull request as draft April 9, 2024 14:32
@sjpfenninger
Copy link
Member Author

sjpfenninger commented Apr 9, 2024

Converting this to draft for now. While running the full workflow I found some issues with snakemake --cleanup-metadata. See snakemake/snakemake#2800

@sjpfenninger sjpfenninger changed the title Update to snakemake 8.10.6 Update to snakemake 8.10.7 Apr 12, 2024
@sjpfenninger sjpfenninger changed the title Update to snakemake 8.10.7 Update to snakemake 8 Apr 12, 2024
@sjpfenninger sjpfenninger marked this pull request as ready for review April 15, 2024 07:26
@timtroendle timtroendle merged commit 4fa9cd0 into calliope-project:develop Apr 15, 2024
4 checks passed
@sjpfenninger sjpfenninger deleted the feature-snakemake-8 branch April 15, 2024 12:52
timtroendle added a commit to timtroendle/euro-calliope that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that conda envs do not include default packages
2 participants