Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve creation of symlink to eurocalliopelib #331

Conversation

sjpfenninger
Copy link
Member

@sjpfenninger sjpfenninger commented Apr 9, 2024

Fixes a newly-identified issue where if you move or rename the workflow directory after already having run once, ensure_lib_folder_is_linked does not work because the symlink exists but points at an invalid location.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

Copy link
Member

@timtroendle timtroendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'd change one comment and the location of the documentation of the change.

Snakefile Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@timtroendle timtroendle merged commit 1518347 into calliope-project:develop Apr 10, 2024
4 checks passed
@sjpfenninger sjpfenninger deleted the feature-fix-moved-workflowdir branch April 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants