Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add core-js as an explicit dependency for npm users #357

Merged
merged 3 commits into from
Feb 10, 2018
Merged

add core-js as an explicit dependency for npm users #357

merged 3 commits into from
Feb 10, 2018

Conversation

Traviskn
Copy link
Contributor

@Traviskn Traviskn commented Feb 9, 2018

fixes #140

@Traviskn
Copy link
Contributor Author

Traviskn commented Feb 9, 2018

"core-js": "2.5.3" is the version of core-js we installed in our project as a dev dependency to get things working, let me know if a different version or perhaps a different version range would be more appropriate

thymikee
thymikee reviewed Feb 10, 2018
View reviewed changes
package.json Outdated
@@ -43,6 +43,7 @@
"clear": "^0.0.1",
"cliui": "^3.2.0",
"clone": "^2.1.1",
"core-js": "2.5.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be good with default semver range ^2.5.3 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the ^!

@thymikee thymikee merged commit bd5190d into callstack:master Feb 10, 2018
zamotany pushed a commit that referenced this pull request Feb 12, 2018
@Traviskn @zamotany
fix(install): add core-js as an explicit dependency for npm users (#357)
16ec3fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Traviskn @satya164 @thymikee