Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack 4 #381

Merged
merged 3 commits into from Mar 5, 2018
Merged

Upgrade to Webpack 4 #381

merged 3 commits into from Mar 5, 2018

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Mar 5, 2018

Merging the branch created by work from #366 and #370.

@czystyl can you make me a favor and test it once more? I've updated webpack to stable v4.1.0

@thymikee thymikee requested a review from czystyl March 5, 2018 20:27
@thymikee
Copy link
Member Author

thymikee commented Mar 5, 2018

For now I've verified iOS works, with HMR too.
I get these deprecation warning though:

(...) Tapable.plugin is deprecated. Use new API on `.hooks` instead
(...) The callback argument was splitted into resolveContext and callback.
(...) The type arguments (string) is now a hook argument (Hook). Pass a reference to the hook instead.

@czystyl
Copy link
Contributor

czystyl commented Mar 5, 2018

It appeared just after the update

@czystyl
Copy link
Contributor

czystyl commented Mar 5, 2018

It looks like everything works except HRM with a Chrome debugger on Android

@thymikee thymikee merged commit 6e6444b into master Mar 5, 2018
@thymikee thymikee deleted the webpack-next branch March 5, 2018 20:56
@thymikee
Copy link
Member Author

thymikee commented Mar 5, 2018

As a followup we'll migrate to new plugins API (ref: https://github.com/webpack/webpack/search?utf8=%E2%9C%93&q=Compiler.hooks&type=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants