-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer #42
Comments
@satya164 i think this can be a function that takes an elevation value and returns the correct shadow, doing a component here is overkill |
@ahmedlhanafy I don't think so. I'd rather do |
We can take inspiration from the paper from material-ui. I second satya, on creating a component over here. It may have a certain // Layer component definition
render() {
<View style=[theme.prepareElevation(this.props.elevation), { otherStyles }] >
{this.props.children}
</View>
} |
Since Google doesn't document the shadow values anywhere (it was documented earlier, but only upto 5dp), this is an approximation.
Since Google doesn't document the shadow values anywhere (it was documented earlier, but only upto 5dp), this is an approximation.
Since Google doesn't document the shadow values anywhere (it was documented earlier, but only upto 5dp), this is an approximation.
Since Google doesn't document the shadow values anywhere (it was documented earlier, but only upto 5dp), this is an approximation.
To have consistent styling on Android and iOS we need
Layer
component (have a better name?) which takes anelevation
prop and renders aView
with correct shadows on both Android and iOS.We'll need this before working on any component with shadows.
The text was updated successfully, but these errors were encountered: