fix: allow styling fab-group action label, renamings #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tarikpnr, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Sep 7, 2022
lukewalczak
reviewed
Sep 15, 2022
lukewalczak
reviewed
Sep 19, 2022
|
Thanks @tarikpnr for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initially
FabGroupcomponent did not have apropfor overriding styling in fab action label. Thus, there was no direct way to override the styling of fab action label. This pr addslabelStyletoactionsprop as well as renaming the previously existinglabelStyletocontainerStyleas it might cause further confusion.labelStyleshould stand for style for label rather than the card style.