Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(breaking): remove deprecated functions #334

Merged
merged 21 commits into from
May 19, 2020

Conversation

mdjastrzebski
Copy link
Member

Summary

Removes deprecated functions and replaces them with stubs throwing error containing reference to the docs.

@mdjastrzebski mdjastrzebski marked this pull request as draft May 19, 2020 12:15
@mdjastrzebski mdjastrzebski marked this pull request as ready for review May 19, 2020 12:33
src/__tests__/render.test.js Outdated Show resolved Hide resolved
src/helpers/getByAPI.js Outdated Show resolved Hide resolved
src/helpers/queryByAPI.js Outdated Show resolved Hide resolved
src/shallow.js Outdated Show resolved Hide resolved
src/waitFor.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
@mdjastrzebski
Copy link
Member Author

@thymikee maybe now is the moment to reformat TS type definitions file?

@thymikee
Copy link
Member

@thymikee maybe now is the moment to reformat TS type definitions file?

I'd prefer doing it in a separate PR, but it should be fine now as well

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's happening!

@thymikee thymikee merged commit 535e0bc into next May 19, 2020
@thymikee thymikee deleted the feature/remove-deprecated-functions branch May 19, 2020 14:18
thymikee added a commit that referenced this pull request May 28, 2020
* WIP

* More changes

* WIP

* Added throwRemovedFunctionError docsRef

* Fixed tests

* Typescript types cleanup

* Cleanup

* Moving some changes from `prepare-2` branch

* Moving some changes from `prepare-2` branch

* Update src/waitFor.js

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

* Update website/docs/Migration20.md

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

* Code review changes

* More code review changes

* Code review changes

* More code review changes

* Added @deprecated messages for TS type defs

* Spelling mistake

* Reformatted index.d.ts

* Removed remaining refs to warnFn

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants