-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(breaking): remove deprecated functions #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # website/docs/Migration20.md
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
thymikee
reviewed
May 19, 2020
thymikee
reviewed
May 19, 2020
@thymikee maybe now is the moment to reformat TS type definitions file? |
I'd prefer doing it in a separate PR, but it should be fine now as well |
thymikee
approved these changes
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's happening!
thymikee
added a commit
that referenced
this pull request
May 28, 2020
* WIP * More changes * WIP * Added throwRemovedFunctionError docsRef * Fixed tests * Typescript types cleanup * Cleanup * Moving some changes from `prepare-2` branch * Moving some changes from `prepare-2` branch * Update src/waitFor.js Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * Code review changes * More code review changes * Code review changes * More code review changes * Added @deprecated messages for TS type defs * Spelling mistake * Reformatted index.d.ts * Removed remaining refs to warnFn Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes deprecated functions and replaces them with stubs throwing error containing reference to the docs.