-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChunkManagerPackage: No value passed for parameter 'p6' #623
Comments
p6 is def isNewArchitectureEnabled() {
return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true"
} I'm guessing you don't have a variable named |
hey @jbroma I got this line in my
I also searched project for this flag and found this in
which is used in
|
@jbroma
it has 7 params but you are passing 6 params here
so there is an error: |
oh yeah, absolutely right, I miscounted the first time apparently! Great find, feel free to open a PR 🎉 |
@jbroma ok, but what value should be passed there as |
good question, according to this it's a very rare optimisation and 99% it should be set to true. Seems like this was also deprecated, and new constructor without this |
@jbroma I'm going to upgrade my react native version to 0.74 to verify if this is a problem with my current 0.71 version or not and I'll let you know I have prepared a patch for "patch-package" if anyone needs it:
|
So the versions affected are < 0.73, 0.72 falls into that so we need to fix this. Thanks for the investigation @krzysztofzaluski, would you like to submit a PR with this change? 🙏 |
@jbroma I didn't updated RN 0.74 to verify it yet, I'm going to do that and let you know if it's the case and then I can make a PR |
I did launch new arch with 0.73 and 0.74 and it didn't seem to be affected, this param was removed so it's essentially ignored from 0.73 |
Closing as this was fixed in 4.1.0, thanks for your help @krzysztofzaluski 🎉 |
Environment
RePack: 4.0.0
React Native: 0.71.7
Description
I get an error while building the application with the "react-native run-android --no-packager" command:
The text was updated successfully, but these errors were encountered: