remove rarely used bridge module optimization #39457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: ## Changelog [Android][General] - hasConstants in ReactModuleInfo does nothing now we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is `WebSocketModule`. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge. however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for `WebSocketModule`, which is probably not moving anything significant. i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan. Reviewed By: cortinico Differential Revision: D49210251
philIip
force-pushed
the
export-D49210251
branch
from
bf0aa82
to
3e04ef6
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: ## Changelog [Android][General] - hasConstants in ReactModuleInfo does nothing now we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is `WebSocketModule`. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge. however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for `WebSocketModule`, which is probably not moving anything significant. i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan. Reviewed By: cortinico Differential Revision: D49210251
philIip
force-pushed
the
export-D49210251
branch
from
3e04ef6
to
08b68c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: ## Changelog [Android][General] - hasConstants in ReactModuleInfo does nothing now we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is `WebSocketModule`. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge. however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for `WebSocketModule`, which is probably not moving anything significant. i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan. Reviewed By: cortinico Differential Revision: D49210251
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
philIip
force-pushed
the
export-D49210251
branch
from
08b68c5
to
16d4b07
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: ## Changelog [Android][General] - hasConstants in ReactModuleInfo does nothing now we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is `WebSocketModule`. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge. however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for `WebSocketModule`, which is probably not moving anything significant. i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan. Reviewed By: cortinico Differential Revision: D49210251
philIip
force-pushed
the
export-D49210251
branch
from
16d4b07
to
a8b730c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
Summary: ## Changelog [Android][General] - hasConstants in ReactModuleInfo does nothing now we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is `WebSocketModule`. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge. however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for `WebSocketModule`, which is probably not moving anything significant. i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan. Reviewed By: cortinico Differential Revision: D49210251
philIip
force-pushed
the
export-D49210251
branch
from
a8b730c
to
f5cb95b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49210251 |
Base commit: 88e19c0 |
|
This pull request has been merged in 691bd0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[Android][General] - hasConstants in ReactModuleInfo does nothing now
we can get rid of this. currently, the default value of hasConstants true, and the only library setting this value to false is
WebSocketModule. this value is only read in bridge mode - it is an optimization that will not initialize the constants dictionary for native modules in bridge.however, we have plenty of native modules that don't provide constants that have not set this flag, so this is only turned on for
WebSocketModule, which is probably not moving anything significant.i would recommend we get rid of this to simplify the ReactModuleInfo deprecation plan.
Reviewed By: cortinico
Differential Revision: D49210251