feat: support bridgeless #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: cc84ed3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Everything looks green, except for the RN 0.73 bridgeless which is expected. I've also fixed multiple issues on Android:
|
|
Canary build for testing available here: https://www.npmjs.com/package/@callstack/repack/v/4.0.1-canary-20240603172122 |
okwasniewski
reviewed
Jun 4, 2024
|
cpp & objc is now reformatted with |
okwasniewski
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add support for bridgeless in new arch for RN >= 0.74 with compat for all other variants. RN 0.74 introduced way more compatibility layers to handle bridgeless on new arch which was not possible on 0.73. Since there is no way to get into the runtime on bridgeless on 0.73, it is excluded from support (it was not turned on by default before 0.74 so it's a rare scenario). This seems to be rather common amongst other libraries having similar issues.
Notes
CallInvokerAPI on both platformsBridgelessCatalystInstancesince it was introduced in0.74-thanks to that we don't need to fork the codeneeded to fork the code on Android because ofFrameworkAPIrequirement that causes compilation error 😔Test plan