Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add databese layer #169

Merged
merged 3 commits into from
Jan 10, 2022
Merged

add databese layer #169

merged 3 commits into from
Jan 10, 2022

Conversation

sea-kai
Copy link
Contributor

@sea-kai sea-kai commented Jan 8, 2022

やったこと

  • interface
  • メソッドの詳細
  • テスト

レビュー時のポイント

残タスク

usecase

備考

@sea-kai sea-kai added the WIP 未完成状態 label Jan 8, 2022
@sea-kai sea-kai self-assigned this Jan 8, 2022
@github-actions github-actions bot added the backend (user) [Backend] API (ユーザー管理用API) label Jan 8, 2022
Copy link
Contributor

@taba2424 taba2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完璧やで!!👍
CIのエラーは make mockgen で直るかと

@github-actions github-actions bot added the test テストの作成・編集 label Jan 9, 2022
Copy link
Contributor

@hamachans hamachans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #169 (84efd4f) into main (c865ff7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   84.52%   84.56%   +0.03%     
==========================================
  Files         140      140              
  Lines        5609     5623      +14     
  Branches      103      103              
==========================================
+ Hits         4741     4755      +14     
  Misses        795      795              
  Partials       73       73              
Flag Coverage Δ
api 90.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/user/database/database.go 92.85% <ø> (ø)
api/internal/user/database/student.go 94.33% <100.00%> (+2.03%) ⬆️

@sea-kai sea-kai merged commit bc2ddfc into main Jan 10, 2022
@sea-kai sea-kai deleted the api/ListStudents/database branch January 10, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend (user) [Backend] API (ユーザー管理用API) mergeable test テストの作成・編集 WIP 未完成状態
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants