Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web/teacher): fix create shift dialog #197

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

taba2424
Copy link
Contributor

やったこと

シフト作成ダイアログにて、 h4 タグの付与箇所が誤っていたので修正しました。
併せて、期間指定の入力フォームのUIの微調整 ( ~ の位置を中央寄せ) にする修正もしています。

レビュー時のポイント

残タスク

備考

@github-actions github-actions bot added the frontend (teacher) [Frontend] Web (管理者・講師用ページ) label Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #197 (3b4d9bf) into main (2b04c00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files         179      179           
  Lines        7016     7016           
  Branches      133      133           
=======================================
  Hits         5796     5796           
  Misses       1124     1124           
  Partials       96       96           
Flag Coverage Δ
student-web 65.17% <ø> (ø)
teacher-web 58.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cher/src/components/organisms/TheShiftEditCard.vue 100.00% <ø> (ø)
...acher/src/components/organisms/TheShiftNewCard.vue 100.00% <ø> (ø)

@taba2424 taba2424 merged commit 486be8e into main Jan 19, 2022
@taba2424 taba2424 deleted the fix/teacher-web/fix-edit-teacher-dialog branch January 19, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend (teacher) [Frontend] Web (管理者・講師用ページ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant