Passing through more React exports #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 145 148 +3
=====================================
+ Hits 145 148 +3
Continue to review full report at Codecov.
|
polytypic
force-pushed
the
feature/react-pass-through
branch
8 times, most recently
from
b91fd26
to
c596ed2
Compare
polytypic
force-pushed
the
feature/react-pass-through
branch
from
c596ed2
to
298d7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass through more React exports.
I would like to avoid passing through exports that don't work. For example
cloneElementis such an export and would need a replacement to work with elements that may have observable properties. See #6. I'm not opposed to supporting it in Karet, but I've never used it myself and I don't have infinite time...Children? Does it work well enough when children may contain observables? Should functions inChildrenbe lifted?The primary goal is to pass through enough React exports that one almost never needs to import React. Is this enough?