Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider supporting React.cloneElement #6

Open
polytypic opened this issue Apr 12, 2017 · 1 comment
Open

Consider supporting React.cloneElement #6

polytypic opened this issue Apr 12, 2017 · 1 comment
Labels
Feedback Welcome Pull Request Welcome

Comments

@polytypic
Copy link
Member

Karet currently only replaces the React.createElement function. If you use React.cloneElement to clone an element without observables in such a way that the new clone has observables in it, then the resulting element currently will not be lifted.
@polytypic
Copy link
Member Author

polytypic commented Apr 15, 2018 •
edited
Loading

Hmm... I've never used React.cloneElement and I can't think of convincing use cases for it—although that doesn't mean that there wouldn't be any. So, I'm happy to reconsider, assuming someone presents really good use cases for it, but otherwise I will likely not implement this. Assuming React.cloneElement can be supported in such a fashion that it can be dead code eliminated (that should be the case) when not used, then a PR is welcome!

@polytypic polytypic mentioned this issue Apr 22, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feedback Welcome Pull Request Welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@polytypic