Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get as alias for view #16

Closed
raimohanska opened this issue Apr 4, 2016 · 3 comments
Closed

Add get as alias for view #16

raimohanska opened this issue Apr 4, 2016 · 3 comments

Comments

@raimohanska
Copy link

I wasted a while wondering where the get function has disappeared. For me, get would seem like a nice pair for set :)

Great work btw!

@raimohanska
Copy link
Author

Also, I'm still looking for modify(lens, f)

@polytypic
Copy link
Member

over is the modify you are looking for.

I've copied the names of operations from Ramda. I agree that the names are not "optimal", but it is more difficult to decide what the best choice of names would be. For instance, I don't particularly like the name set. I would prefer update as in "functional record update". Ramda also uses the name update for a functional update operation on arrays whose semantics coincides with partial lens set.

current proposed
view get
set set
over  modify

Perhaps it would not hurt to have the proposed aliases. More opinions welcome!

polytypic added a commit that referenced this issue Apr 9, 2016
See #16 and #17 for some background.
@polytypic
Copy link
Member

2.2.0 introduced get and modify as synonyms for (deprecated) view and over
3.0.0 removed view and over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants