Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working towards 3.0.0. #18

Merged
merged 14 commits into from
Apr 10, 2016
Merged

Working towards 3.0.0. #18

merged 14 commits into from
Apr 10, 2016

Conversation

polytypic
Copy link
Member

See #16 and #17 for some background.

@polytypic polytypic force-pushed the 3.0.0 branch 2 times, most recently from 063a8fa to d232eb6 Compare April 9, 2016 07:08
@polytypic
Copy link
Member Author

@raimohanska and @milankinen, if you have a moment to look through this pull request and comment it would be cool.

@milankinen
Copy link

Looks nice! It seems that partial.lenses still uses Ramda internally? In that case how about importing only the used ramda functions (import fn from "ramda/lib/fn") so that the final bundle would be smaller?

@polytypic
Copy link
Member Author

Hmm... Interesting idea, but if I understand correctly, then importing individual functions from Ramda would only lead to a smaller bundle in case that no other part of the application imports Ramda. That is because Ramda is built into a single source file and if you import that (import R from "ramda") and individual functions (e.g. import equals from "ramda/src/equals") you will effectively get the individual functions twice. Are minifiers intelligent enough to eliminate such duplication?

@polytypic
Copy link
Member Author

And thanks for the feedback, @milankinen!

@polytypic polytypic merged commit 759b97e into master Apr 10, 2016
@polytypic polytypic deleted the 3.0.0 branch April 10, 2016 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants